test(milvus): cast exposed_port to str for substring assert#1035
Closed
Tranquility2 wants to merge 1 commit into
Closed
test(milvus): cast exposed_port to str for substring assert#1035Tranquility2 wants to merge 1 commit into
Tranquility2 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
- Coverage 83.29% 83.12% -0.18%
==========================================
Files 16 16
Lines 1754 1754
Branches 193 193
==========================================
- Hits 1461 1458 -3
- Misses 236 240 +4
+ Partials 57 56 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tranquility2
force-pushed
the
fix/milvus-test-port-type
branch
from
dccae63 to
a7df3d7
Compare
Contributor
Author
|
Superseded by the src-layout migration (#1045) and subsequent test fixes on main. |
alexanderankin
pushed a commit
that referenced
this pull request
Jun 6, 2026
The repo currently has no `codecov.yml`, so Codecov uses its strict defaults: any coverage drop (project) and any patch under 100% are reported as failing statuses on PRs. This produces frequent red checks on small refactors even when coverage is unchanged or trivially impacted (e.g. #1035, #1038). This change adds a minimal `codecov.yml` that keeps useful signal while removing the noise: - `coverage.status.project.default.threshold: 1%` — allow up to a 1% project-coverage drop without failing. - `coverage.status.project.default.if_ci_failed: success` — don't double-report when the CI run itself failed. - `coverage.status.patch.default.informational: true` — still report patch coverage, but never block PRs on it. - `comment.require_changes: true` — only post a PR comment when coverage actually changes. Validated with `curl --data-binary @codecov.yml https://codecov.io/validate` → `Valid!`. Real coverage regressions will still surface (anything > 1% project drop), and contributors keep getting patch-coverage feedback — it just won't block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_run_milvus_successasserts:get_exposed_port()returnsint, so theincheck against a stringurlraises:CI evidence:
test (3.10|3.13|3.14, milvus)jobs fail this assertion for bothv2.4.0andv2.4.4.Fix
Cast
exposed_porttostrbefore the substring check.